toph/Sworm
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Clean up redundant folderPath and locked props in SurfaceHost #5

New issue
Open
opened 2026-09-02 02:35:45 -04:00 by toph · 0 comments
toph commented 2026-09-02 02:35:45 -04:00
Owner
Copy link

Location

src/lib/features/workbench/surfaces/SurfaceHost.svelte

Problem

SurfaceHost.svelte explicitly passes folderPath={activeTab.folderPath} and locked={activeTab.locked} to surface components (TextSurface, DiffSurface, TaskSurface, SessionTerminal, etc.), which already receive the complete tab object containing those exact properties.

Suggested Fix

Simplify surface component props to read folderPath and locked directly from tab, removing the duplicate prop bindings in SurfaceHost and the receiving surface definitions.

### Location `src/lib/features/workbench/surfaces/SurfaceHost.svelte` ### Problem `SurfaceHost.svelte` explicitly passes `folderPath={activeTab.folderPath}` and `locked={activeTab.locked}` to surface components (`TextSurface`, `DiffSurface`, `TaskSurface`, `SessionTerminal`, etc.), which already receive the complete `tab` object containing those exact properties. ### Suggested Fix Simplify surface component props to read `folderPath` and `locked` directly from `tab`, removing the duplicate prop bindings in `SurfaceHost` and the receiving surface definitions.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
toph/Sworm#5
No description provided.